feat(e2e): run tests in dedicated urunc-test namespace#728
Open
mdryaan wants to merge 1 commit into
Open
Conversation
Signed-off-by: Md Raiyan <alikhurshid842001@gmail.com>
✅ Deploy Preview for urunc canceled.
|
Contributor
Author
|
@cmainas PTAL whenever you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
nerdctl and ctr e2e tests previously ran in the default containerd namespace, leaving containers and images mixed with host workloads and risking cross-test contamination. This change introduces a dedicated
urunc-testnamespace:BeforeSuitecreates it,AfterSuiteremoves it, and every nerdctl and ctr command is prefixed with--namespace urunc-test.crictl is unaffected it uses the
k8s.ionamespace via the CRI endpoint. docker is unaffected it has its own daemon with no containerd namespace concept.verifyNoStaleFilesand thenamespaceTestconfig path lookup are also updated to cover theurunc-testnamespace.Related issues
How was this tested?
Build and lint pass locally:
go build ./... # no errors
golangci-lint run --timeout=5m # 0 issues
To verify namespace creation and cleanup on a host with containerd running:
Full e2e verification requires a host with containerd, nerdctl, and ctr installed alongside a supported VMM (QEMU, Firecracker, or Solo5).
LLM usage
N/A
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).